Subchapter 3.35
reference/polish.mdMarkdown6 KBView on GitHub
Additional context needed: quality bar and shipping constraints.
Polish is refinement, never concealed redesign. Preserve the incumbent visual world, content, behavior, and everything outside scope. If the concept itself is wrong, say so and recommend redesign or bolder instead of smuggling in a replacement.
A detector result is defect evidence, not proof of quality. Inspect the rendered experience and real interaction path.
Read DESIGN.md and representative tokens, shared components, patterns, and neighboring flows. If no formal system exists, use coherent project conventions.
Classify each drift before fixing it:
Fix the cause at the narrowest correct level. Ask when a binding system principle cannot be inferred.
Use the feature yourself at the surface’s representative sizes: desktop and mobile on the web; on a native platform (ios / android / adaptive), the shipped device classes on the simulator, emulator, or hardware, captured per the platform reference’s Verifying the build section. Determine:
If a prior critique exists, use it as one input:
"<skill-base-dir>/scripts/impeccable" critique-storage latest "<resolved target>" --jsonExit 0 returns JSON with the latest snapshot’s body and an exact snapshot_file identity. Retain snapshot_file until the end of the pass. For a local file target, the helper compares the file’s exact current content fingerprint with the fingerprint captured by critique. Unchanged staged, unstaged, or untracked content remains current; any byte change, deletion, or replacement with a non-file closes the backlog it identified while preserving its trend history and exits 2. A URL target has no local fingerprint and remains current until explicitly closed. When current, incorporate relevant P0/P1 findings from body and name the snapshot read. Exit 2 means none exists or the target changed. Perform an independent pass either way.
Separate functional defects from cosmetic ones and fix in this order:
Do not perfect one corner while leaving the rest below the same quality bar.
Walk the complete path again with mouse, keyboard, and touch where applicable. Check:
Follow the quality guidance supplied by impeccable context and hooks, then run any other relevant QA commands. Context requests a manual scan only when no automatic detector is active; never add another detector pass. Fix real defects and document only narrow intentional exceptions. A clean scan does not replace visual judgment.
Finish with a source diff: remove accidental churn, orphaned code, redundant values, and temporary artifacts. Ship only when the feature is functionally complete and consistently finished across the path.
When this pass clears every Priority Issue it took from a snapshot, close that snapshot:
"<skill-base-dir>/scripts/impeccable" critique-storage close "<resolved target>" "<snapshot_file returned by latest>"This closes only the snapshot this pass actually processed; if a newer critique landed meanwhile, its backlog stays live. Do not close when no snapshot was read, when snapshot_file was not retained, or when Priority Issues remain.