Review Package

1#!/usr/bin/env bash
2# Generate a review package: commit list, stat summary, and the net
3# diff with extended context, written to a file the reviewer reads in one
4# call. Using the recorded per-task BASE (not HEAD~1) keeps multi-commit
5# tasks intact.
6#
7# Usage: review-package [-C DIR] PLAN_FILE BASE HEAD [OUTFILE]
8# Default OUTFILE: <repo-root>/.superpowers/sdd/<plan-basename>/review-<base7>..<head7>.diff
9# (named per range, so a re-review after fixes gets a distinct fresh file).
10# The repository is the one sdd-repo names; -C DIR runs as if started in DIR,
11# as in sdd-workspace.
12set -euo pipefail
13
14here=$(cd "$(dirname "$0")" && pwd)
15if [ "${1:-}" = "-C" ]; then
16  [ -d "${2:-}" ] || { echo "bad -C directory: ${2:-}" >&2; exit 2; }
17  cd "$2"
18  shift 2
19fi
20
21if [ $# -lt 3 ] || [ $# -gt 4 ]; then
22  echo "usage: review-package [-C DIR] PLAN_FILE BASE HEAD [OUTFILE]" >&2
23  exit 2
24fi
25
26plan=$1
27base=$2
28head=$3
29[ -f "$plan" ] || { echo "no such plan file: $plan" >&2; exit 2; }
30
31# Invoke via bash rather than direct exec: some extractors (Python zipfile)
32# strip Unix exec bits when unpacking marketplace packages (#2040).
33repo=$("${BASH:-bash}" "$here/sdd-repo" --with-commit)
34
35git -C "$repo" rev-parse --verify --quiet "$base" >/dev/null || { echo "bad BASE: $base" >&2; exit 2; }
36git -C "$repo" rev-parse --verify --quiet "$head" >/dev/null || { echo "bad HEAD: $head" >&2; exit 2; }
37
38# Range guards (exit 3): a wrong-branch HEAD yields a range that is empty or
39# not rooted at BASE; either would silently produce a bogus review package.
40git -C "$repo" merge-base --is-ancestor "$base" "$head" || { echo "HEAD is not a descendant of BASE: ${base}..${head}" >&2; exit 3; }
41[ "$(git -C "$repo" rev-list --count "${base}..${head}")" -gt 0 ] || { echo "empty commit range: ${base}..${head}" >&2; exit 3; }
42
43if [ $# -eq 4 ]; then
44  out=$4
45else
46  dir=$("${BASH:-bash}" "$here/sdd-workspace" "$plan")
47  out="$dir/review-$(git -C "$repo" rev-parse --short "$base")..$(git -C "$repo" rev-parse --short "$head").diff"
48fi
49
50{
51  echo "# Review package: ${base}..${head}"
52  echo
53  echo "## Commits"
54  git -C "$repo" log --oneline "${base}..${head}"
55  echo
56  echo "## Files changed"
57  git -C "$repo" diff --stat "${base}..${head}"
58  echo
59  echo "## Diff"
60  git -C "$repo" diff -U10 "${base}..${head}"
61} > "$out"
62
63commits=$(git -C "$repo" rev-list --count "${base}..${head}")
64echo "wrote ${out}: ${commits} commit(s), $(wc -c < "$out" | tr -d ' ') bytes"